Skip to content

fix: add platform to chunk envelope item headers #5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2025
Merged

fix: add platform to chunk envelope item headers #5041

merged 2 commits into from
Mar 31, 2025

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Mar 31, 2025 •
edited
Loading

The profiling team needs to be able to rate limit different platform SDKs differently, but can't simply use the SDK info name field in Relay, since some platforms have multiple different SDKs, like the JS ecosystem.

Related to getsentry/sentry-javascript#15758 and getsentry/sentry-java#4287

#skip-changelog

Base automatically changed from armcknight/meta/tooling-update to main March 31, 2025 19:59
@codecov Codecov
Copy link

codecov bot commented Mar 31, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.719%. Comparing base (fbb7656) to head (9b532a1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Sentry/SentryEnvelopeItemHeader.m 66.666% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5041       +/-   ##
=============================================
+ Coverage   92.711%   92.719%   +0.007%     
=============================================
  Files          672       672               
  Lines        82298     82304        +6     
  Branches     29981     29972        -9     
=============================================
+ Hits         76300     76312       +12     
+ Misses        5898      5894        -4     
+ Partials       100        98        -2
Files with missing lines Coverage Δ
...es/Sentry/Profiling/SentryProfilerSerialization.mm 85.823% <100.000%> (+0.054%) ⬆️
...yProfilerTests/SentryContinuousProfilerTests.swift 97.976% <100.000%> (+0.005%) ⬆️
Sources/Sentry/SentryEnvelopeItemHeader.m 97.222% <66.666%> (-2.778%) ⬇️

... and 9 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbb7656...9b532a1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.49 ms 1247.98 ms 24.49 ms
Size 22.30 KiB 832.42 KiB 810.11 KiB

@armcknight armcknight merged commit 443fb02 into main Mar 31, 2025
73 of 74 checks passed
@armcknight armcknight deleted the armcknight/profiling/fix/platform-name-in-chunk-env-header branch March 31, 2025 21:19
@armcknight armcknight mentioned this pull request Apr 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@indragiek indragiek indragiek approved these changes

@philipphofmann philipphofmann Awaiting requested review from philipphofmann philipphofmann is a code owner

@philprime philprime Awaiting requested review from philprime philprime is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@armcknight @indragiek